Skip to content

Fix crash when setting Anisotropic property after Global Illumination disabled by adding validity checks for GI and enabled state #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash when setting Anisotropic property after Global Illumination disabled by adding validity checks for GI and enabled state #3084

wants to merge 1 commit into from

Conversation

@XINJIANGMO
Copy link
Contributor

@XINJIANGMO XINJIANGMO commented Sep 10, 2025

🦟 Bug fix

Fixes #3083

Summary

If we switch enabled from checked state to unchecked state , plugin will release gi object. If now we uncheck Anisotropic property , this plugin will set lightingDirty to true and call this->dataPtr->gi->SetAnisotropic(...).

Reproduce

  1. gz sim shapes.sdf
  2. from the plugin dropdown, select the Global Illumination VCT plugin
  3. check Enabled
  4. uncheck Enabled
  5. uncheck Anisotropic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@XINJIANGMO XINJIANGMO requested a review from arjo129 as a code owner September 10, 2025 03:37
@azeey
Copy link
Contributor

azeey commented Sep 10, 2025

I wouldn't consider this to be a critical bug since (1) GI is not a commonly used feature (2) you have to do those specific steps to run into the issue. So let's hold off from merging. Thanks for the fix @XINJIANGMO though!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 10, 2025
@iche033
Copy link
Contributor

iche033 commented Sep 10, 2025

I wouldn't consider this to be a critical bug since (1) GI is not a commonly used feature (2) you have to do those specific steps to run into the issue. So let's hold off from merging. Thanks for the fix @XINJIANGMO though!

This is targeted at main so I think it should be fine? We can do the backport to jetty but hold off from merging?

@azeey
Copy link
Contributor

azeey commented Sep 10, 2025

This is targeted at main so I think it should be fine? We can do the backport to jetty but hold off from merging?

It will be difficult to remember which PRs we need to backport if we don't do it immediately. I guess we can create the backport PRs to gz-sim10 but not merge it. But that requires all the maintainers to be aware of this new way of doing things, so I'd prefer not to merge it for now until we have a discussion and have a clear policy about PRs targetting main during the code freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@iche033 iche033 iche033 approved these changes

@arjo129 arjo129 Awaiting requested review from arjo129 arjo129 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XINJIANGMO @azeey @iche033 @ahcorde